Skip to content

sync.py: Don't print traceback on missing libgpod_ctypes and eyed3.mp3 #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auouymous merged 1 commit into from
Jul 12, 2022
Merged

sync.py: Don't print traceback on missing libgpod_ctypes and eyed3.mp3 #1335

auouymous merged 1 commit into from
Jul 12, 2022

Conversation

@tpikonen
Copy link
Contributor

@tpikonen tpikonen commented Jul 12, 2022

Current master prints rather excessive log output with the -v option from sync.py if libgpod_ctypes and eyed3 are not installed:

1657639825.704173 [gpodder.sync] INFO: iPod sync not available
Traceback (most recent call last):
  File "/home/tpikonen/src/gpodder/master-worktree/src/gpodder/sync.py", line 51, in <module>
    from gpodder import libgpod_ctypes
  File "/home/tpikonen/src/gpodder/master-worktree/src/gpodder/libgpod_ctypes.py", line 37, in <module>
    libgpod = ctypes.CDLL('libgpod.so.4')
  File "/usr/lib/python3.10/ctypes/__init__.py", line 374, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: libgpod.so.4: cannot open shared object file: No such file or directory
1657639825.705882 [gpodder.sync] INFO: eyeD3 MP3 not available
Traceback (most recent call last):
  File "/home/tpikonen/src/gpodder/master-worktree/src/gpodder/sync.py", line 60, in <module>
    import eyed3.mp3
ModuleNotFoundError: No module named 'eyed3'

Remove the printing of exception info from these log messages, so the output reduces to:

1657640118.353999 [gpodder.sync] INFO: iPod sync not available
1657640118.354441 [gpodder.sync] INFO: eyeD3 MP3 not available

@auouymous auouymous merged commit 925a497 into gpodder:master Jul 12, 2022
@auouymous
Copy link
Member

auouymous commented Jul 12, 2022

Thank you for fixing that.

@tpikonen tpikonen deleted the sync-no-traceback branch July 13, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpikonen @auouymous