Skip to content

MPRIS extension fixes #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auouymous merged 2 commits into from
Apr 29, 2022
Merged

MPRIS extension fixes #1286

auouymous merged 2 commits into from
Apr 29, 2022

Conversation

@tpikonen
Copy link
Contributor

@tpikonen tpikonen commented Apr 28, 2022

Two commits:

  1. Some players occasionally send negative 'pos' values to MPRIS. Clamp these values to 0.
  2. The fix for exceptions caused by missing position values in Fix exceptions on mpris-listener extension #1265 causes 'pos' to be set to None, which causes further exceptions. If there's no position (or status) property, do nothing. Refactor the code in question slightly.

tpikonen added 2 commits April 28, 2022 10:24
@tpikonen
mpris-listener: Guard against negative 'pos' from D-Bus
a87d240 
If negative position values are received from MPRIS, treat them as 0.
@tpikonen
mpris-listener: Don't set non-existant D-Bus properties
f26c26b 
Improves commit 1aae54f.
@auouymous auouymous merged commit 3b2415e into gpodder:master Apr 29, 2022
@auouymous
Copy link
Member

auouymous commented Apr 29, 2022

LGTM, thanks.

@tpikonen tpikonen deleted the mpris-negpos branch April 29, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpikonen @auouymous