Show episodes without downloadable content. #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aca63be to
9d29426
Compare
tpikonen
requested changes
Apr 11, 2022
Contributor
|
Seems to work fine, and the code is ok, except for the one point in the review. |
Non-media RSS feeds only have a textual description and can't be subscribed to in gpodder. Some media feeds lack downloadable content and can only be accessed from the website. In both cases, gpodder removes the episodes without any feedback to the user as to why, making it appear to be a problem in gpodder. This patch adds those episodes but prevents automatic download and displays a proper error when a manual download is attempted. The episodes also get a web browser icon to indicate they lack downloadable content. While not downloadable or transferable to media devices, gpodder can be used to notify the user when new episodes are available and they can be accessed by clicking through to the website
9d29426 to
1cc7941
Compare
Member
|
LGTM, merge at your leisure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-media RSS feeds only have a textual description and can't be subscribed to in gpodder. Some media feeds lack downloadable content and can only be accessed from the website. In both cases, gpodder removes the episodes without any feedback to the user as to why, making it appear to be a problem in gpodder.
This patch adds those episodes but prevents automatic download and displays a proper error when a manual download is attempted. The episodes also get a web browser icon to indicate they lack downloadable content. While not downloadable or transferable to media devices, gpodder can be used to notify the user when new episodes are available and they can be accessed by clicking through to the website.