youtube_dl.is_supported_url(): Don't fail on None #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return False when url is None. The url can be None for example when an episode.link attribute is tested for supported media in PodcastEpisode.from_podcastparser_entry().
Contributor
Author
|
Fixed the class name in the commit message. |
Member
|
The commit says |
Contributor
Author
|
See these lines in PodcastEpisode.from_podcastparser_entry(). The url is temporarily switched to the link when testing the link for compatible media. |
Member
|
Ah, thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSS episodes which have no media and have an empty or non-existing link element cause an exception in youtube_dl.is_supported_url(). In this case None is passed as the url argument.
This patch makes is_supported_url() return False when url is None.