Remove 'from youtube_dl' imports #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I can confirm that uninstalling youtube-dl throws a 'youtube_dl module not found' error. But this patch fails when yt-dlp is not installed because youtube-dl stores them in the utils module. This seems to work for both cases. try:
import yt_dlp as youtube_dl
from yt_dlp.utils import DownloadError, ExtractorError, sanitize_url
except:
import youtube_dl
from youtube_dl.utils import DownloadError, ExtractorError, sanitize_urlBut simply inserting |
These caused an exception when run on a system where only yt-dlp is installed.
Contributor
Author
|
Thanks for testing, the exceptions actually are also in I changed the patch to use |
Member
|
Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
youtube_dlmodule from my system (but leftyt_dlp) and got an exception in the youtube-dl extension when running gPodder master:This patch fixes the import error.