Refactor play_or_download() progress tab action code. #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue with the toolbar cancel button turning off and on when entering the progress tab, even though it can't cancel anything until a selection is made. Properly cancels failed tasks manually removed from progress tab. Not cancelling would leave the error icon and prevent downloading or cancelling. The download, pause and cancel actions in toolbar and Episodes menu can now be used to control downloads in the progress tab. The delete menu item in Episodes menu removes the download from list. This also allows keyboard accelerators to be used, such as the Delete key for removing tasks. Accelerators for cancel, and maybe download/pause, should added in a future PR. The progress tab context menu now has the same ordering as the other menus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the toolbar cancel button turning off and on when entering the progress tab, even though it can't cancel anything until a selection is made.
Properly cancels failed tasks manually removed from progress tab. Not cancelling would leave the error icon and prevent downloading or cancelling.
The download, pause and cancel actions in toolbar and Episodes menu can now be used to control downloads in the progress tab. The delete menu item in Episodes menu removes the download from list. This also allows keyboard accelerators to be used, such as the Delete key for removing tasks. Accelerators for cancel, and maybe download/pause, should added in a future PR.
The progress tab context menu now has the same ordering as the other menus.