Skip to content

Conversation

@JuanCanham
Copy link
Contributor

Quick fix,

I think ideally we would handle this when credentials are entered but the UI, but the UI doesn't seem to validated them.

#1234

@elelay
Copy link
Member

elelay commented Mar 2, 2022

Should the message start with "Server doesn't recognize your mygpo account" or similar, and then offer the advice about username not email?

@auouymous
Copy link
Member

The message should probably also be a single translatable string instead of two.

@auouymous
Copy link
Member

The message could use some punctuation and tweaks.

Could not find your device.

Check login is a username (not email)
and the device name matches one in your account.

We can run make messages after merging, so anything you didn't manually modify shouldn't be included in the commit.

@auouymous
Copy link
Member

I just tested this and the """ quoting not only indents the strings in translations but also on the dialog. It would be better to wrap each line in a string.

                    message = _(
                        'Could not find your device.\n'
                        '\n'
                        'Check login is a username (not an email)\n'
                        'and that the device name matches one in your account.'
                    )

I have never used gpodder.net, do you know if this message happens anywhere other than when clicking the replace on server button on the gpodder.net preferences page?

@JuanCanham
Copy link
Contributor Author

This is only for error handling on the set_subscriptions api call, and only an email / bad deviceid can cause this

@auouymous auouymous merged commit d7b5843 into gpodder:master Mar 9, 2022
@auouymous
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants