Create partial file when reusing cancelled tasks. #1228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The partial file for a cancelled task is deleted, but the task is not removed from progress list while other tasks are downloading. Downloading the cancelled episode again would reuse the existing task without creating a new partial file. This prevented resuming the download after restarting gPodder, and caused the youtube-dl extension to fail if used to re-download it.
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial file for a cancelled task is deleted, but the task is not removed from progress list while other tasks are downloading. Downloading the cancelled episode again would reuse the existing task without creating a new partial file. This prevented resuming the download after restarting gPodder, and caused the youtube-dl extension to fail if used to re-download it.