YoutubeDL partial file fixes #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a partial file exists with an extension appended to it, it should always be renamed even if the partial file without an extension was written to. Yt-dlp sometimes writes part of the file to the partial file (bug), but always writes all of the file to a partial file with an extension.
YoutubeDL can append an extension to the partial file, creating additional partial files. Adaptive formats create up to three more partial files. Cancelling a download will leave behind these extra partial files, and requires manual removal outside of gPodder.
Member
|
LGTM 👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch fixes an issue caused by yt-dlp that results in a truncated download and a partial file containing the full download which must be manually renamed or deleted outside of gPodder.
The second patch cleans up YoutubeDL partial files after cancelling a download.