Skip to content

without the ActivateTab, no progress bar (extended) #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elelay merged 7 commits into from
Jun 30, 2022
Merged

without the ActivateTab, no progress bar (extended) #1211

elelay merged 7 commits into from
Jun 30, 2022

Conversation

@elelay
Copy link
Member

@elelay elelay commented Jan 15, 2022

Further work on #1209
Still to be tested before merge

@elelay elelay mentioned this pull request Jan 15, 2022
Closed
@arne182
Copy link
Contributor

arne182 commented Jan 15, 2022

Excellent. Thanks for integrating my change.

@elelay elelay added the windows label Mar 16, 2022
elelay added 2 commits June 19, 2022 23:35
@elelay
Merge remote-tracking branch 'origin/master' into win-taskbar_progres…
50e12aa 
…s-fix
@elelay
taskbar_progress: prevent gpodder never exiting
181617b 
when closing with download in progress, if not running the event loop a bit
the program is stuck at exit.
Note: taskbar progress doesn't show in windows classic theme
@elelay elelay force-pushed the win-taskbar_progress-fix branch from 42d6cf0 to 181617b Compare June 19, 2022 21:40
@elelay elelay mentioned this pull request Jun 20, 2022
Closed
@auouymous
Copy link
Member

auouymous commented Jun 24, 2022

Code looks fine. I tested on a Win10 machine today and I don't think it works. I enabled the extension and downloaded an episode but nothing happened on the taskbar.

@elelay
Copy link
Member Author

elelay commented Jun 28, 2022 •
edited
Loading

I enabled the extension and downloaded an episode but nothing happened on the taskbar.

do you use a "classic" theme? It doesn't show with it but with modern theme.
Also gPodder might need to restart before it works

@auouymous
Copy link
Member

auouymous commented Jun 29, 2022

By classic do you mean what win95 looked like? It wasn't my computer so I don't know what theme it had, but its taskbar looked like https://i.insider.com/55b7aebbdd08958f7f8b4600?width=2160 (without that white search box). I closed and killed gpodder (in task manager) at least a dozen times, so pretty sure it was started with the extension.

If it works for you on win10 then it should be good to go, because that machine is heavily configured and maybe something is disabled.

@elelay elelay merged commit 7410d2c into master Jun 30, 2022
@elelay elelay deleted the win-taskbar_progress-fix branch June 30, 2022 05:52
@elelay
Copy link
Member Author

elelay commented Jun 30, 2022

By classic do you mean what win95 looked like? It wasn't my computer so I don't know what theme it had, but its taskbar looked like https://i.insider.com/55b7aebbdd08958f7f8b4600?width=2160 (without that white search box). I closed and killed gpodder (in task manager) at least a dozen times, so pretty sure it was started with the extension.

yes it is the same theme I have. No idea why it didn't work on this system...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elelay @arne182 @auouymous