Remove deprecated Gtk features from main gPodder window #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
118d8d3 to
625669e
Compare
Contributor
Author
|
Rebased to current master. |
Member
|
Why did you drop Gtk translations for the previous PRs but then declare Dgtk_ for the ones here? |
Contributor
Author
|
TBH, I can't remember for sure, but at least for the strings in ui-files the translation domains can't be mixed. Should I replace the GTK translated strings by gpodder strings (i.e. remove Dgtk)? |
Member
|
It would be best to use the Gtk translations because many languages might not get updated. But mixing gpodder and Gtk translations might cause inconsistencies if gpodder's translation doesn't match Gtk's. So maybe drop Dgtk_. |
* Replace stock-ids with standard icon names * Remove deprecated rules-hint from treeAvailable * Set can-focus to True in search entries * Remove use-underline from buttons
Resize: * hbox_search_episodes * hboxContainer * hboxUpdateFeeds * vbox_episode_list * vbox42 * vboxChannelNavigator * vMain * hboxDownloadSettings * hboxDownloadLimit * hboxDownloadRate
The '_builder_expose' argument to GtkBuilderWidget.__init__() allowed binding of names in the ui-file to objects defined outside of the ui-file. Glade does not allow setting properties to values which are not defined in the ui-file, so we set GTK/Gobject properties explicitly. This is made with a new kwarg '_gtk_properties' in GtkBuilderWidget.__init__() which is a dict with a (object_id, property_name) key.
625669e to
222dba3
Compare
Contributor
Author
|
Ok, Dgtk is now gone. |
Member
|
LGTM and works on my system. A few new strings to translate to French... |
Member
|
Thanks, and sorry for the long delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining changes from #1129.