Remove deprecated GTK features from episodeselector #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace GTK stock labels with text * Replace icon stock-ids with standard icon names * Remove deprecated Alignment widgets * Set always show image in OK button
* Rename gPodderEpisodeSelector constructor kwarg 'stock_ok_button' to 'ok_button'. Change callers in main.py to use it with text labels instead of Gtk.STOCK_* values * Set transient for parent widget
Member
|
I know about downloading episodes, deleting episodes and deleting channels. What else uses this that shows the Should OK, Remove, Download, Mark as old, Select all and Select none have mneumonics? Some of them have use-underline set but have no underscore in the label. |
Set use-underline on all buttons in gpodderepisodeselector.ui. Add underscore mnemonics to the special 'gpodder-download' button and in 'remove-button' and 'ok-button' args of callers in main.py.
Contributor
Author
|
I added mnemonics to all buttons. @auouymous, in addition to the uses you mentioned, episodeselector is used in gPodderSyncUI to select episodes to delete. I think the button labels in the ui-file are only used there. |
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1129 with additional fixes.