Fix youtube-dl re-download after a failed download #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling run() with CANCELLED state only returns without performing any work. The CANCELLING state actually deletes the partial file and recycles the task.
livestream to be streamed, after realizing it was a livestream. This however caused the youtube-dl extension to fail when downloading DRM content after gpodder failed to download it, because the partial file was missing. This removes that fix and properly cancels the failed task before streaming to remove the partial file. Fixes gpodder#1147.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch fixes cancelling so it actually removes partial file. Second patch reverts part of #1044 and fixes #1147.