Remove deprecated GTK features from simple dialogs #1156
Conversation
|
The welcome buttons lost their chunkiness, and the ability to tab between them. Are the icons on buttons deprecated? They made it easy to quickly distinguish groups of buttons without reading the text. Gpodder has no translations for "Paste" and while it has "Save" from the channel dialog, I didn't see any translations for it. And the gtk domain would guarantee "Cancel", "Add" and "Close" work for all languages. Removing the icons and translations will make it harder for non-English users. |
32c5ba4 to
1beb962
Compare
|
Thanks again for the review. The latest push fixes the Welcome dialog and adds back the underscore accelarators to buttons. The button icons are indeed deprecated, they need to be explicitly added, see https://docs.gtk.org/gtk3/property.Settings.gtk-button-images.html The problem with using GTK translations in ui-files is that GtkBuilder allows setting the translation domain only on a per file basis. If a translation is not actively maintained, then this will be a regression. However, the number of new translatable strings added when stock strings are removed is likely very small, so at least it's not a big translation task. |
|
Why did you disable the labels in the welcome buttons? The cancel button on welcome dialog lost some of its margin. Unrelated to this PR, but there is a lot of inconsistent padding around close buttons through out gpodder. Some have none (about, subscribe and edit config) and the others vary. We should probably choose a value and apply it to all dialogs. Will you be adding the accelerator to the close button on preferences dialog? I've only seen a couple languages receive translations this year, so it could take quite a while to update these. @elelay Are you okay with dropping the gtk translations, and the button icons? |
1beb962 to
5ce190c
Compare
|
Added margins to Welcome Cancel button and accelerators to Preferences dialog buttons. The button label sensitivity was turned off when I was fixing the tab focusing, does it cause problems? |
|
Ya, it changes the text color of the button to indicate disabled. I tested tab focus yesterday to see if that was why you disabled the labels and they didn't become tab stops when enabled. Were they tab stops for you? |
gpodderwelcome.ui: * Save with Glade 3.38.2 * Replace gtk-cancel stock with text label * Replace padding with margins * Replace border-width with margins * Set can-focus to True on buttons welcome.py: Set transient for parent
gpodderaddpodcast.ui: * Save with Glade 3.38.2, require GTK 3.16 * Set can-focus to True where needed * Replace GTK stock labels with text addpodcast.py: Set transient for parent
gpodderconfigeditor.ui: * Save with Glade 3.38.2, require GTK 3.16 * Replace gtk-close with text label * Use Dialog internal action_area for Close button * Add underline accelerator for '_Show All' configeditor.py: Set transient for parent
gpodderexporttolocalfolder.ui: * Save with Glade 3.38.2 * Replace GTK stock labels with text exportlocal.py: Set transient for parent (was not set before)
Also require GTK 3.16.
5ce190c to
fb8d71b
Compare
|
Ok, the labels now have sensitive=True. They were left to False from trying to fix the tab stops which were broken for some other reason. Also the button label appearance is the same here, whether sensitive or not. |
|
LGTM. |
|
merged, thanks :-) |
Removes some deprecated GTK features from gPodderWelcome, gPodderAddPodcast, gPodderConfigEditor and gPodderExportToLocalFolder. Split from #1129.
Changes from #1129: