Preferences: Remove deprecated GTK features #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally removed in d9a0c7d.
Member
|
Splitting would have been nice before I spent a week or two reviewing the original, now I must start over. But I will accept it as it is easier to squash smaller PRs into single commits. Why is the podcastdirectory commit in this PR if something else broke it? |
Contributor
Author
|
Oh, sorry if this made things harder. The purpose of the splitting was of course to make the review easier. You can check that the changes to gpodderpreferences.ui are identical to #1129 and that the rest of the commits are trivial. The podcastdirectory is here because submitting a one-line PR felt silly at the time. This can be split out if needed. |
Member
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1129. Save the ui-file with Glade to regularize it, fix the collateral damage and remove deprecated GTK features.
Sets the required GTK version to max 3.16 everywhere and updates README.md to mention this.
Also sets 'transient-for' to parent in podcastdirectory, as that was broken in a previous commit.