Delay restoring window position until after it has been shown. #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
reviewed
Aug 28, 2021
Member
thp
left a comment
There was a problem hiding this comment.
Could this cause the window "jumping" from original mapping to when it's loaded fully? Wonder if we should do it twice? (once so that window managers that honor the request will move the window, then second time with delay so that other window managers deal with it properly) -- is there a list of window managers that have one behavior vs the other?
The window manager might not honor the move request until after the window is shown. This can cause window contents to be rendered at a shifted offset inside the window borders.
f9e9a13 to
dd299bc
Compare
Member
Author
|
Thanks for bringing that up, the window can jump, so I change it to move before and after. There is a split second where the window contents are shifted but the delayed move quickly corrects that. I doubt there is a list. |
Member
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The window manager might not honor the move request until after the window is shown. This can cause window contents to be rendered at a shifted offset inside the window borders.