Allow distributions to disable the update check. #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oturpe
reviewed
Aug 17, 2021
| if diff > (60 * 60 * 24) * self.config.software_update.interval: | ||
| self.config.software_update.last_check = int(time.time()) | ||
| self.check_for_updates(silent=True) | ||
| if not os.path.exists(gpodder.no_update_check_file): |
There was a problem hiding this comment.
Would it be cleaner if this check was made earlier?
The results of time diff calculation does not affect this check
so it would be possible to short circuit earlier.
Of course this is a matter of style,
and gpodder is not my project in any way,
so it may be that I am just used to different conventions.
Member
Author
There was a problem hiding this comment.
The time check is a fast calculation that only succeeds once every 5 days, unless the user changes it. Where as the file check must access a potentially slow storage device, and increase startup time.
There was a problem hiding this comment.
Makes sense, being fast at runtime is more important than tiny readability gains.
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package managers can install
/usr/share/gpodder/no-update-checkto disable the automatic check at startup, and theSoftware updatemenu item.Fixes #1103.