Skip to content

Fix linting issues from #1054 #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auouymous merged 2 commits into from
Jul 30, 2021
Merged

Fix linting issues from #1054 #1112

auouymous merged 2 commits into from
Jul 30, 2021

Conversation

@auouymous
Copy link
Member

@auouymous auouymous commented Jul 28, 2021

I can't test syncing, can someone confirm the change from lambda to def is correct? There are four other linting errors I don't know how to fix. @blushingpenguin What is the purpose of the comment in the last error?

src/gpodder/util.py:2277:5: E129 visually indented line with same indent as next logical line
src/gpodder/gtkui/main.py:3704:5: E129 visually indented line with same indent as next logical line
src/gpodder/gtkui/main.py:3733:46: E114 indentation is not a multiple of four (comment)
src/gpodder/gtkui/main.py:3733:46: E116 unexpected indentation (comment)

@elelay elelay force-pushed the fix-1054-linting branch from 9c60658 to 106e2f4 Compare July 29, 2021 19:52
@elelay
Copy link
Member

elelay commented Jul 29, 2021

@auouymous here is a fix for remaining linter errors.
See b40f283 for the last one: @blushingpenguin removed the self.set_download_list_state callback in the end of on_synchronize_episodes

@elelay
Copy link
Member

elelay commented Jul 29, 2021

Syncing to a /tmp/XXXX directory works with the patches.

@auouymous auouymous merged commit 3c2362e into gpodder:master Jul 30, 2021
@auouymous auouymous deleted the fix-1054-linting branch July 30, 2021 00:02
@blushingpenguin
Copy link
Contributor

blushingpenguin commented Jul 31, 2021

@auouymous that was just some code i commented out temporarily, but then didn't use and forgot to delete the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@auouymous @elelay @blushingpenguin