gtkui: properly scale cover/pill on high resolution displays #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollieparanoid
commented
Jul 23, 2021
Set it to 3.10, as it will be required in a follow-up patch. The currently maintained upstream version is 3.24, which was released in 2018-09.
Fix the cover images and "pill" looking blurry on high resolution displays. For example, when the adaptive version of gPodder is used with Phosh on the PinePhone. Get the scale parameter from the gtkTreeView object and pass it down to the cover thumbnail size and to draw_text_pill. If the scaling is not 1, then use the new draw_iconcell_scale() function to draw the pixbuf with high resolution.
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the cover images and "pill" looking blurry on high resolution displays. For example, when the adaptive version of gPodder is used with Phosh on the PinePhone.
Get the scale parameter from the gtkTreeView object and pass it down to the cover thumbnail size and to draw_text_pill. If the scaling is not 1, then use the new draw_iconcell_scale() function to draw the pixbuf with high resolution.
Screenshots
Before and after, with scaling factor 2:
Regular UI
Details
Details
Adaptive UI (@tpikonen)
Details
Details