Skip to content

Conversation

@tpikonen
Copy link
Contributor

I'm trying to reduce the delta between adaptive and master. This PR moves the 'Select All' and 'Select None' buttons in gPodderPodcastDirectory window to a separate box (or row), so that the window can be made narrower. After this patch the only change needed to gPodderPodcastDirectory in adaptive is to replace GtkPaned with HdyFlap.

@elelay
Copy link
Member

elelay commented May 10, 2021

Trouble is it's less optimized for wider screens (like a phone in landscape mode or a tiled layout).
How can we reconcile both?

@tpikonen
Copy link
Contributor Author

GtkFlowBox would neatly solve this problem. It just happens to be a GTK4 widget.

Incidentally, what are your thoughts on porting gPodder to GTK4?

@elelay
Copy link
Member

elelay commented May 16, 2021

Nice: just what I looked for in gtk3: a reflow would adapt to both landscape-ish and portrait-ish displays!
Regarding Gtk4, I'm eager to fix compatibility, but in no rush to push it as a hard requirement by using new components

@tpikonen tpikonen force-pushed the narrow-podcastdir branch from a165628 to 7598b79 Compare May 23, 2021 17:48
@tpikonen
Copy link
Contributor Author

Bah, I was wrong: GtkFlowBox has been in Gtk since version 3.12. The PR is now updated to use it. The toggles in podcastdirectory are also made wider to be a little more touch friendly.

@auouymous
Copy link
Member

I don't use that dialog but I think this looks so much better. The only problem I see is the increased gap below buttons

@tpikonen
Copy link
Contributor Author

The gap was the unused action area in GtkDialog. That cannot be removed from GtkDialog, so I changed the window to a normal GtkWindow.

@elelay
Copy link
Member

elelay commented May 24, 2021

looks good, except the Subscriptions > delete podcasts dialog, where for some reason Delete and Cancel stay on the 2nd line...

@tpikonen
Copy link
Contributor Author

'Delete podcasts' uses the episode selector dialog. I don't mind converting it also though :)

@auouymous
Copy link
Member

LGTM.

The episode selector dialog might be more difficult to get on a single line. The select buttons have a selection count label on the line, and there is a Mark as old button on the second line. Also, the selection count label is directly above the download button, so you can quickly see how many will be downloaded. I've never used it, but it would be nice if the delete podcast dialog also showed selected count to indicate how many would be deleted.

@elelay
Copy link
Member

elelay commented May 26, 2021

'Delete podcasts' uses the episode selector dialog. I don't mind converting it also though :)

ha ha indeed it's the episode selector dialog.

@elelay elelay merged commit 7ef74ee into gpodder:master May 26, 2021
@elelay
Copy link
Member

elelay commented May 26, 2021

Merged, thanks!
I'm open to @auouymous suggestions, but on another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants