-
-
Notifications
You must be signed in to change notification settings - Fork 217
Allow a narrower podcast directory window #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Trouble is it's less optimized for wider screens (like a phone in landscape mode or a tiled layout). |
|
GtkFlowBox would neatly solve this problem. It just happens to be a GTK4 widget. Incidentally, what are your thoughts on porting gPodder to GTK4? |
|
Nice: just what I looked for in gtk3: a reflow would adapt to both landscape-ish and portrait-ish displays! |
Allows the podcast directory window to be made narrower. Requires Gtk version 3.12.
a165628 to
7598b79
Compare
|
Bah, I was wrong: GtkFlowBox has been in Gtk since version 3.12. The PR is now updated to use it. The toggles in podcastdirectory are also made wider to be a little more touch friendly. |
|
I don't use that dialog but I think this looks so much better. The only problem I see is the increased gap below buttons |
|
The gap was the unused action area in GtkDialog. That cannot be removed from GtkDialog, so I changed the window to a normal GtkWindow. |
|
looks good, except the Subscriptions > delete podcasts dialog, where for some reason Delete and Cancel stay on the 2nd line... |
|
'Delete podcasts' uses the episode selector dialog. I don't mind converting it also though :) |
|
LGTM. The episode selector dialog might be more difficult to get on a single line. The select buttons have a selection count label on the line, and there is a |
ha ha indeed it's the episode selector dialog. |
|
Merged, thanks! |
I'm trying to reduce the delta between adaptive and master. This PR moves the 'Select All' and 'Select None' buttons in gPodderPodcastDirectory window to a separate box (or row), so that the window can be made narrower. After this patch the only change needed to gPodderPodcastDirectory in adaptive is to replace GtkPaned with HdyFlap.