Skip to content

Fix overlapping audio notifications for high-priority messages #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmattheis merged 1 commit into from
Nov 6, 2025
Merged

Fix overlapping audio notifications for high-priority messages #869

jmattheis merged 1 commit into from
Nov 6, 2025

Conversation

@LaurenceJJones
Copy link
Contributor

@LaurenceJJones LaurenceJJones commented Nov 1, 2025

fix #850

  • Add audioNotification utility to manage single Audio instance reuse
  • Debounce audio playback with 300ms cooldown after playback ends
  • Skip playback if audio is currently playing or in cooldown window
  • Replace per-message Audio creation with shared instance in reactions.ts

@LaurenceJJones LaurenceJJones requested a review from a team as a code owner November 1, 2025 18:57
@codecov
Copy link

codecov bot commented Nov 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.14%. Comparing base (71e38b9) to head (2ab9fb5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #869   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files          56       56           
  Lines        2225     2225           
=======================================
  Hits         1761     1761           
  Misses        360      360           
  Partials      104      104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jmattheis
jmattheis reviewed Nov 5, 2025
View reviewed changes
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I've added a review for explanation, but will fix the remarks in an own commit. You don't have to do anything.

@jmattheis jmattheis force-pushed the fix/audio-notification-debounce branch from e6cd969 to 4f498fc Compare November 5, 2025 19:52
@jmattheis jmattheis force-pushed the fix/audio-notification-debounce branch from 4f498fc to 2ab9fb5 Compare November 5, 2025 21:21
@jmattheis jmattheis merged commit 2b67bc3 into gotify:master Nov 6, 2025
3 checks passed
@LaurenceJJones LaurenceJJones deleted the fix/audio-notification-debounce branch November 7, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmattheis jmattheis jmattheis approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Throttle notification sound in web UI

2 participants

@LaurenceJJones @jmattheis