Skip to content

fix: serving gotify on a subpath #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmattheis merged 1 commit into from
Sep 13, 2025
Merged

fix: serving gotify on a subpath #840

jmattheis merged 1 commit into from
Sep 13, 2025

Conversation

@jmattheis
Copy link
Member

@jmattheis jmattheis commented Sep 13, 2025

Fixes #839

@jmattheis jmattheis requested a review from a team as a code owner September 13, 2025 11:58
@codecov
Copy link

codecov bot commented Sep 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.54%. Comparing base (0239db0) to head (5c2a972).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #840   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files          56       56           
  Lines        2645     2645           
=======================================
  Hits         2104     2104           
  Misses        450      450           
  Partials       91       91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@williamdes

This comment was marked as resolved.

Sign in to view
@jmattheis jmattheis merged commit 9e1455f into master Sep 13, 2025
4 checks passed
@jmattheis jmattheis deleted the fix-subpath branch September 13, 2025 12:04
@jmattheis
Copy link
Member Author

jmattheis commented Sep 13, 2025

There is already documentation for caddy with subpath: https://gotify.net/docs/caddy

@williamdes
Copy link

williamdes commented Sep 13, 2025

Thank you for the quick fix and release !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eternal-flame-AD eternal-flame-AD eternal-flame-AD approved these changes

+1 more reviewer

@williamdes williamdes williamdes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subpaths are broken for JS files

4 participants

@jmattheis @williamdes @eternal-flame-AD