fix message layout #819
fix message layout #819
Conversation
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## upgrade-ui #819 +/- ##
===========================================
Coverage 79.54% 79.54%
===========================================
Files 56 56
Lines 2645 2645
===========================================
Hits 2104 2104
Misses 450 450
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| SHELL := /bin/bash | ||
| ifdef GOTOOLCHAIN | ||
| GO_VERSION=$(GOTOOLCHAIN) | ||
| else |
There was a problem hiding this comment.
I think we should display the app images even on small screens (I can already smell the issues that the app icons aren't visible :D)
Maybe it could be formatted like this?
Maybe this could even be the default formatting on all sizes.
There was a problem hiding this comment.
Could we do this change in a separate PR independent of upgrade-ui?
There was a problem hiding this comment.
I suppose, it is complicated and I think discussion potentially change is needed.
I personally don't use this icon feature very often: reason simply being it kind of becomes an ad-hoc graphics design problem where the icon needs to be readable on any screen and the file has to be appropriately compressed so it loads fast. More often than not I find just text description being better.
For example I name my servers after mountain names: nokogiri, gorgonio, ontake, etc. It is simply much more recognizable to write the name in text than find an appropriate image for these mountains that displays well under any size.
I think that is also why most "uptime monitoring" apps don't have app icon feature, users have difficulty sourcing images that display well in a list or card grid like fashion and it's more clean and neat without it.
But I feel the text app name absolutely should be there for both accessibility and user choice reasons.
There was a problem hiding this comment.
I personally agree with the usefulness of the icons, but I think there are a significant amount of users that would. Maybe we could hide the image if it's the default one, and only display it when the user has uploaded a custom one.
But I feel the text app name absolutely should be there for both accessibility and user choice reasons.
Agreed, but we should probably omit it, if the title is equal to the app name.
| import TimeAgo from 'react-timeago'; | ||
| import Container from '../common/Container'; | ||
| import {Markdown} from '../common/Markdown'; | ||
| import * as config from '../config'; |
There was a problem hiding this comment.
The changes currently break <code> blocks that are wider than the message box. And also markdown formatted messages
{
"title": "Title",
"message": "hello\n```\nmycodeaoeouanetohunaotheuntaoheuntoaheunt oheuntoheunthoeaunthaoeunth\n```\n",
"priority": 5,
"extras": { "client::display": { "contentType": "text/markdown" } }
}
There was a problem hiding this comment.
Huhh, I did test with markdown formatted images. Let me double check ..
Should we just have a sample database/script that posts a list of various messages so it is easy to check nothing breaks?
There was a problem hiding this comment.
Yeah, we definitely should have this.
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
a9ef013 to
8741d1e
Compare
Signed-off-by: eternal-flame-AD <yume@yumechi.jp>
|
Some minor changes:
|
Not sure if it shows up like this on your end as well. Tried fixing it, can't find a way to make App Logos show up on really small screens neatly so I think we should just hide it: it saves metered traffic as well.
Before:
After: