Consistency and Accessibility Improvements of the user-related UIs #815
+21
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the username doesn't have to be an email, having email as the type is incorrect. This change also makes it more consistent with the way it is defined in the login form.
…login The login form says username and password and should be consistently used throughout.
As the username doesn't have to be an email, having email as the type is incorrect. This change also makes it more consistent with the way it is defined in the login form.
The login form says username and password and should be consistently used throughout.
The login form says username and password and should be consistently used throughout.
This ensures password managers can properly save the form field's values.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
=======================================
Coverage 79.55% 79.55%
=======================================
Files 56 56
Lines 2646 2646
=======================================
Hits 2105 2105
Misses 450 450
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eternal-flame-AD
approved these changes
Jul 24, 2025
Member
eternal-flame-AD
left a comment
There was a problem hiding this comment.
lgtm and great commit history management!
I will let the owner take a second look before merging. He knows frontend best.
jmattheis
reviewed
Jul 25, 2025
Contributor
Author
Thanks for the quick review and the kind words about my commit history! I really appreciate you passing this along, I'm sure that helped speed things up :) |
jmattheis
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making gotify, it's truly awesome!
Just some small things I noticed that could be improved, let me know in case you wouldn't want one of the changes, I intentionally split them up into multiple commits so it would be easy to remove any changes you wouldn't want.
I tried adding justifications to the commit's bodies, if anything is unclear don't hesitate to ask back.