Loading animations instead of "no messages #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added isLoading to MessageStore state - Added conditional rendering for it - All Loading spinners now use the `LoadingSpinner` component
jmattheis
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds loading animations to the application panels when loading messages, instead of just showing "no messages". I've used the already existing
LoadingSpinnercomponent for this.Hint: This PR also changes the size of the
LoadingSpinnerfrom 150 to 40 (used after login and (since now) on message load). This looks way more modern in my opinion. Feel free to revert the last commit of this PR if you disagree.Closes #658