Make assert and golden packages compatible with other golden packages#271
Merged
dnephin merged 1 commit intogotestyourself:mainfrom Jul 30, 2023
Merged
Make assert and golden packages compatible with other golden packages#271dnephin merged 1 commit intogotestyourself:mainfrom
dnephin merged 1 commit intogotestyourself:mainfrom
Conversation
03626a8 to
16c4393
Compare
16c4393 to
56c3123
Compare
1 task
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-pb-go
Mar 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [gotest.tools/v3](https://togithub.com/gotestyourself/gotest.tools) | indirect | patch | `v3.5.0` -> `v3.5.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gotestyourself/gotest.tools (gotest.tools/v3)</summary> ### [`v3.5.1`](https://togithub.com/gotestyourself/gotest.tools/releases/tag/v3.5.1) [Compare Source](https://togithub.com/gotestyourself/gotest.tools/compare/v3.5.0...v3.5.1) #### What's Changed - Make assert and golden packages compatible with other golden packages by [@​dnephin](https://togithub.com/dnephin) in [https://github.com/gotestyourself/gotest.tools/pull/271](https://togithub.com/gotestyourself/gotest.tools/pull/271) - Also remove cr from file by [@​filintod](https://togithub.com/filintod) in [https://github.com/gotestyourself/gotest.tools/pull/273](https://togithub.com/gotestyourself/gotest.tools/pull/273) - fs: add go doc links by [@​dolmen](https://togithub.com/dolmen) in [https://github.com/gotestyourself/gotest.tools/pull/275](https://togithub.com/gotestyourself/gotest.tools/pull/275) #### New Contributors - [@​filintod](https://togithub.com/filintod) made their first contribution in [https://github.com/gotestyourself/gotest.tools/pull/273](https://togithub.com/gotestyourself/gotest.tools/pull/273) **Full Changelog**: gotestyourself/gotest.tools@v3.5.0...v3.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #270
Lookup the
updateflag, and only define it when it's not defined by another package. This works as long asgotest.tools/v3is imported after the other package. Other packages can make themselves compatible withgotest.tools/v3by using the same approach.