drop go1.16 from test-matrix, replace deprecated io/ioutil, and update golangci-lint to v1.49.0#245
Merged
dnephin merged 5 commits intogotestyourself:mainfrom Oct 6, 2022
Merged
Conversation
Both go1.16 and go1.17 reached EOL; keeping go1.17 for now, as there may still be projects that are slightly behind. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also replacing some of them, as there's more linters that check for this now (revive being one of them), so "fixing" them prevents having to add more linters to the list. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1011a81 to
d7bf7af
Compare
internal/maint/maint.go:1:1: package-comments: should have a package comment (revive)
package maint // import "gotest.tools/v3/internal/maint"
internal/format/diff.go:1:1: package-comments: should have a package comment (revive)
package format
icmd/internal/stub/main.go:1:1: package-comments: should have a package comment (revive)
package main
internal/source/defers.go:1:1: package-comments: should have a package comment (revive)
package source
internal/assert/assert.go:1:1: package-comments: should have a package comment (revive)
package assert
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Also replaced deprecated linters:
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.
WARN [runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
d7bf7af to
5b51cec
Compare
thaJeztah
commented
Oct 4, 2022
| @@ -1,3 +1,4 @@ | |||
| // Package main produces a test-binary used in tests. | |||
Contributor
Author
There was a problem hiding this comment.
FWIW, I was a bit on the fence wether to disable this specific check in the linter or to add the (quite "boiler-plate-y" comments), but most packages already had a Package description, so I thought it'd be useful to be a bit more "strict", and run the linter.
Contributor
Author
|
@dnephin @vdemeester 👋 PTAL 🤗 |
vdemeester
approved these changes
Oct 4, 2022
Contributor
Author
|
YW! Hope you're doing well! |
This was referenced Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits for details