assert: document that filename and line number are included#233
Merged
dnephin merged 1 commit intogotestyourself:mainfrom Apr 16, 2022
Merged
assert: document that filename and line number are included#233dnephin merged 1 commit intogotestyourself:mainfrom
dnephin merged 1 commit intogotestyourself:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small improvement that I missed in #229
Anyone not familiar with the stdlib
testingpackage may not know how the filename and line number work. This PR adds some detail to the package godoc for theassertpackage to explain how it works, and give some guidance for how to keep it working when assertions are called from helper functions.