go.mod: update dependencies#217
Merged
dnephin merged 2 commits intogotestyourself:mainfrom Mar 14, 2021
Merged
Conversation
This version provides compatibility with Go 1.3+ native error wrapping Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
Author
Ah, looks like some changes are needed in a test (possibly different output format?)edit: breakage is in golang.org/x/tools; perhaps better to include in #218 |
Contributor
Author
|
sigh.. so it was just random; issue looks to be in |
e293578 to
2e30eeb
Compare
thaJeztah
commented
Mar 14, 2021
assert/opt/opt_test.go
Outdated
| func matchPaths(fixture interface{}, filter func(gocmp.Path) bool) []string { | ||
| rec := &pathRecorder{filter: filter} | ||
| gocmp.Equal(fixture, fixture, gocmp.FilterPath(rec.record, gocmp.Ignore())) | ||
| sort.Strings(matches) |
Contributor
Author
There was a problem hiding this comment.
Looks like go-cmp filter now may result in results to be returned in
random random order; this sorts the results before comparing, but I'm
not sure if order is important (in which case this could actually be
a bug)
Version v0.5.x provides various improvements to the reporter output; https://github.com/google/go-cmp/releases full diff: google/go-cmp@v0.4.0...v0.5.5 Looks like go-cmp filter now may result in results to be returned in random random order; this sorts the results before comparing, but I'm not sure if order is important (in which case this could actually be a bug) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 65c6ba6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
Author
|
looks like CI is hitting concurrency limits 😞 |
dnephin
approved these changes
Mar 14, 2021
Member
dnephin
left a comment
There was a problem hiding this comment.
LGTM
The order shouldn't matter, because the filter will be applied to all matches. These filters have been difficult to test. It is not the first time that an upgrade has broken these tests.
Contributor
Author
|
Thanks for confirming; I wasn't entirely sure, so thought I'd best call it out 👍 🤗 |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.mod: github.com/pkg/errors v0.9.1
This version provides compatibility with Go 1.3+ native error wrapping
go.mod: github.com/google/go-cmp v0.5.5
Version v0.5.x provides various improvements to the reporter output;
https://github.com/google/go-cmp/releases
full diff: google/go-cmp@v0.4.0...v0.5.5