bg: ensure init is complete before returning#216
Merged
ernado merged 3 commits intogotd:masterfrom May 2, 2022
rusq:master
Merged
bg: ensure init is complete before returning#216ernado merged 3 commits intogotd:masterfrom rusq:master
ernado merged 3 commits intogotd:masterfrom
rusq:master
Conversation
Contributor
Author
|
FIXED: If the With (c *Client) defined as: type Client struct {
cl *telegram.Client
auth auth.UserAuthenticator
sendcodeOpts auth.SendCodeOptions
}// func (c *Client) Run() error {
stop, err := bg.Connect(c.cl)
if err != nil {
return err
}
defer func() {
if err := stop(); err!=nil {
log.Print(err)
}
}()
// even if Run fails with error, we will reach this point
flow := auth.NewFlow(c.auth, c.sendcodeOpts)
// *** the following will hang indefinitely ***
if err := c.cl.Auth().IfNecessary(ctx, flow); err != nil {
return err
}
log.Debug("auth success")
return nil
} |
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
===========================================
+ Coverage 55.47% 71.87% +16.39%
===========================================
Files 48 9 -39
Lines 1871 256 -1615
===========================================
- Hits 1038 184 -854
+ Misses 752 51 -701
+ Partials 81 21 -60 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an issue, where i started Auth immediately after calling Connect, and it seems that the Auth kicked in before the client.Run has finished initialisation.
The code that revealed the problem:
To confirm this theory, I added a time.Sleep(500*time.Millisecond) after Connect, and before Auth (as shown on the commented line above)
Introducing the synchronisation in Connect fixes the described problem.