Merged
Conversation
91cc173 to
4720d3d
Compare
Collaborator
Author
|
@jlnr Do you want podspec updated to use mojoAL or leave that be for now? |
Member
|
Yes please, let's replace it all :) |
0ca6638 to
9d9da16
Compare
Collaborator
Author
|
@jlnr I got all the CI passing. iOS and OSX should probably get manually checked to ensure they work as expected. |
Collaborator
Author
|
iOS still uses OpenAL since mojoAL relies on SDL and Gosu's iOS implementation doesn't use SDL as far as I know. |
…nd lib64/, updated visual studio project
896f47e to
50b1c9b
Compare
50b1c9b to
efd152b
Compare
jlnr
approved these changes
Jan 20, 2022
Member
jlnr
left a comment
There was a problem hiding this comment.
Had to add the header_mappings_dir so that installation through CocoaPods also works on macOS. Otherwise it seems to work just fine. Thanks so much!! Can't wait to never see oal-soft warnings in my Linux terminals :)
Comment on lines
+656
to
+661
| #ifdef __SSE__ | ||
| if (!SDL_HasSSE()) { | ||
| SDL_QuitSubSystem(SDL_INIT_AUDIO); | ||
| return NULL; /* whoa! Better order a new Pentium III from Gateway 2000! */ | ||
| } | ||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.