Updated SDL_sound, disabled and excluded midi support#606
Merged
jlnr merged 3 commits intogosu:masterfrom Jan 15, 2022
Merged
Conversation
Member
|
Thanks. Unfortunately, it seems SDL_sound is not compatible with the version of SDL2 that ships with Ubuntu 18.04: Maybe this can be fixed manually by providing a fallback for this function. |
ad96689 to
d4c28fe
Compare
Collaborator
Author
|
@jlnr I removed the offending Looks like I also need to update the Visual Studio project... Good thing I got Windows booted on my main machine. |
Member
|
Thanks! How much manual tweaking was involved? Would it be possible to automate the updating process? Although I hope that libsdl2-sound-dev (or so) will make its way into Ubuntu 22.04 so that we can just depend on it at some point. |
Collaborator
Author
|
I only needed to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.