Merged
Conversation
ghost
approved these changes
Jan 24, 2020
ferhatelmas
reviewed
Jan 24, 2020
| // than the largest message do not provide any benefit. | ||
| // | ||
| // Depending on the distribution of message sizes, setting the buffer size to | ||
| // to a value less than the maximum expected message size can greatly reduce |
Contributor
There was a problem hiding this comment.
why not one line diff?
Contributor
Author
There was a problem hiding this comment.
The authors appear to try and keep comment line length to a maximum of 80 characters and having line breaks as close to 80 characters as possible. I did the same but it resulted in having to reshuffle the subsequent lines.
If no one cares about this any more then a one line diff would suffice.
Contributor
There was a problem hiding this comment.
Sounds good, thanks for the care into the details.
ferhatelmas
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.