Skip to content

[bug] Registered encoder doesn't work for struct pointer types#174

Merged
elithrar merged 2 commits intogorilla:masterfrom
tkhametov:bug/custom-encoder-not-working-for-poiter-structures
May 20, 2021
Merged

[bug] Registered encoder doesn't work for struct pointer types#174
elithrar merged 2 commits intogorilla:masterfrom
tkhametov:bug/custom-encoder-not-working-for-poiter-structures

Conversation

@tkhametov
Copy link
Copy Markdown
Contributor

@tkhametov tkhametov commented May 20, 2021

Fixes #173

Summary of Changes

  1. Added the check for struct pointer types, not allowing going through nested fields recursively if there is a registered encoder for this type
  2. Added tests

@tkhametov tkhametov changed the title Bug/custom encoder not working for poiter structures [bug] Registered encoder doesn't work for struct pointer types May 20, 2021
@tkhametov tkhametov mentioned this pull request May 20, 2021
Closed
@elithrar elithrar merged commit 8285576 into gorilla:master May 20, 2021
@tkhametov tkhametov deleted the bug/custom-encoder-not-working-for-poiter-structures branch May 20, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elithrar elithrar elithrar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] Registered encoder doesn't work for struct pointer types

3 participants

@tkhametov @elithrar @timurkhametov