fix(mux.go): use cleaned path as URL.Path#674
fix(mux.go): use cleaned path as URL.Path#674with-shrey wants to merge 2 commits intogorilla:mainfrom
Conversation
|
The go http servers follows the same convention to redirect when the request path isn't clean. See here. I am unsure why ? It could be to protect against |
|
@chaudyg that could be true for the HTML website server. But for REST Api based servers, this is not very intuitive as per my understanding |
|
@elithrar could use your advice here |
Needs positive & negative tests - for the mentioned issue and the delated code. |
There's no difference here: these are web servers. We can't break existing cases. |
|
I'm not discouraging anyone here. Changes proposed in the PR are not required and we can mark it as NA. Reason is because as @chaudyg mentioned already in comment |
|
Makes sense
…On Tue, 31 May, 2022, 3:31 pm Mustaque Ahmed, ***@***.***> wrote:
I'm not discouraging anyone here. Changes proposed in the PR are not
required and we can mark it as NA.
Let me know what do you think?
Reason is because as @chaudyg <https://github.com/chaudyg> mentioned
already in comment
<#674 (comment)>
net/http/server.go file we have implemented Redirect and same we're doing
it in our mux. Removing Redirect from mux will not align with the
original implementation.
—
Reply to this email directly, view it on GitHub
<#674 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGAVQE4MQOWMLQDOVHV3FJDVMXPRLANCNFSM5U5DKZRA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@elithrar we can close the PR and its related issue. |
|
superseded by #578 |
Fixes #673
Summary of Changes