fix: regression in vars extract for wildcard host#579
Merged
elithrar merged 1 commit intogorilla:masterfrom Jul 11, 2020
Merged
fix: regression in vars extract for wildcard host#579elithrar merged 1 commit intogorilla:masterfrom
elithrar merged 1 commit intogorilla:masterfrom
Conversation
Contributor
Author
|
// cc @elithrar |
Contributor
|
Can you please add regression tests that capture this change? :) |
Contributor
Author
|
@elithrar let me look at those - thanks for quickly looking at the PR. |
Contributor
Author
|
would it be possible to make a release today if all goes well? @elithrar |
7 tasks
Contributor
|
I'll commit to having this reviewed before the end of the weekend. |
Continuing from PR gorilla#447 we have to add extra check to ignore the port as well add tests to cover this case
d2eaf19 to
8769a15
Compare
Contributor
Author
|
@elithrar updated the PR with the tests, the same tests don't run with master branch. |
elithrar
approved these changes
Jul 11, 2020
Contributor
elithrar
left a comment
There was a problem hiding this comment.
TODO: push a release / note this as a subtle behavior change
Contributor
Author
|
Possible to tag a release @elithrar ? |
Contributor
Author
Contributor
6 tasks
This was referenced Mar 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing from PR #447 we have to add extra
check to ignore the port as well