Merged
Conversation
elithrar
suggested changes
Oct 24, 2019
Contributor
elithrar
left a comment
There was a problem hiding this comment.
Can’t accept changes that would break the public API.
mux.go
Outdated
| // ErrSkipRouter is used as a return value from WalkFuncs to indicate that the | ||
| // router that walk is about to descend down to should be skipped. | ||
| var SkipRouter = errors.New("skip this router") | ||
| var ErrSkipRouter = errors.New("skip this router") |
Contributor
There was a problem hiding this comment.
This is a breaking change. That golint complains is unfortunate, but this predates golint.
fharding1
approved these changes
Oct 24, 2019
elithrar
approved these changes
Nov 21, 2019
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: