Use subtests for middleware tests#478
Merged
elithrar merged 2 commits intogorilla:masterfrom Jun 29, 2019
Merged
Conversation
elithrar
suggested changes
Jun 28, 2019
Contributor
elithrar
left a comment
There was a problem hiding this comment.
LGTM bar the one comment.
Contributor
|
PS: can you rebase this against master so CI will fire? Else I’ll push a rebased branch over the top of this later today! |
Contributor
Author
|
@elithrar rebased 👌 |
Contributor
|
One more time please @fharding1? 🥀 I think I was missing a checkbox on the @circleci side for triggering builds from forks (which wasn't on by default). |
3f30a7f to
6d83780
Compare
Contributor
Author
|
Rebased ✔️ |
elithrar
approved these changes
Jun 29, 2019
Contributor
|
Thanks again, @fharding1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #409, awaiting feedback on whether I should update
old_test.gobefore tagging that this completely closes that issue.Uses Go subtests for all the middleware tests. I don't love the solution for
CORSMethodMiddleware, because those tests don't really make sense, because that middleware doesn't really make sense (my bad, see #476). The new tests I wrote in #477 use subtests and completely replace the current tests for that, though.