Ignore ErrNotFound while matching Subrouters#438
Merged
elithrar merged 1 commit intogorilla:masterfrom Jan 8, 2019
Merged
Conversation
Contributor
|
What if you have a router whose only routes are subrouters, and all of them return ErrNotFound? |
Contributor
Author
|
In this case no route should match and https://github.com/gorilla/mux/blob/master/mux.go#L167 should be reached. This sets I've checked this through this test: If you think it useful, I will add it to my PR. BTW: This fixes #437 |
Contributor
|
Yes I think adding this test is useful just to verify that this and any future changes won't break this. |
MatchErr is set by the router to ErrNotFound if no route matches. If no route of a Subrouter matches the error can by safely ignored. This implementation only ignores these errors and does not ignore other errors like ErrMethodMismatch.
1dbc0d7 to
02287a9
Compare
Contributor
Author
|
I've added the test. |
Contributor
|
Thanks @g-w! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatchErr is set by the router to ErrNotFound if no route matches. If
no route of a Subrouter matches the error can by safely ignored. This
implementation only ignores these errors and does not ignore other
errors like ErrMethodMismatch.