distinguish between explicit and implicit *#118
Merged
elithrar merged 1 commit intogorilla:masterfrom Apr 16, 2018
Merged
Conversation
Contributor
Contributor
Author
|
Anything I can do to move this forward? |
Contributor
|
Whoops. looks like I was the blocker here. Looks like this makes ACAO * always turned on, which is safe? I don't really know why you would want that but I don't see any issues with it. |
Contributor
Author
|
My intent here is that ACAO * is returned when:
Otherwise, the current origin is reflected on the assumption that it has been previously validated by either a custom validator or a matching origin. |
Contributor
|
SGTM! |
Contributor
|
@elithrar what's the word on this one? |
elithrar
approved these changes
Apr 16, 2018
Contributor
|
Sorry for the long delay here! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117 by distinguishing between an explicit and implicit
AllowedOrigins([]string{"*"}). This means that the origin will be reflected when a custom validator says it's okay and there is no contradictoryAllowedOrigins(...)configuration.If there is no custom validator, or the validator is paired with an explicit
*(oops), then the allowed origin is a properly opaque*that will disable credentials.Scrutiny and ideas for alternate implementations are welcome! 😓