Don't return the origin header when configured to *#116
Merged
elithrar merged 1 commit intogorilla:masterfrom Nov 1, 2017
ejcx:ej/fix-acao
Merged
Don't return the origin header when configured to *#116elithrar merged 1 commit intogorilla:masterfrom ejcx:ej/fix-acao
elithrar merged 1 commit intogorilla:masterfrom
ejcx:ej/fix-acao
Conversation
There's no reason to allow for a server to reflect all origin headers. This has caused numerous security problems in the past. - cyu/rack-cors#126 - https://nodesecurity.io/advisories/148 - captncraig/cors@cc1cf75 Some helpful blog posts on the topic: - https://ejj.io/misconfigured-cors/ - http://blog.portswigger.net/2016/10/exploiting-cors-misconfigurations-for.html
Contributor
|
Thanks for raising this Evan - appreciate it. Agree with the assessment. |
Contributor
|
Tagged v1.3.0 with this https://github.com/gorilla/handlers/releases/tag/v1.3.0 |
Contributor
Author
|
Woot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason to allow for a server to reflect all origin headers.
This has caused numerous security problems in the past.
Some helpful blog posts on the topic: