use http.StatusOK as initial value for responseLogger.status#103
Merged
elithrar merged 1 commit intogorilla:masterfrom May 23, 2017
Merged
use http.StatusOK as initial value for responseLogger.status#103elithrar merged 1 commit intogorilla:masterfrom
elithrar merged 1 commit intogorilla:masterfrom
Conversation
Contributor
|
Looks good to me. Can you add a test so we can avoid regressions? |
Contributor
Author
|
@kisielk OK. I just added a simple unit test for responseLogger. |
Contributor
Author
|
@kisielk Is there any problem with this pull request? |
elithrar
approved these changes
May 23, 2017
Contributor
|
Thanks @damoye! |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handler never call w.WriteHeader or w.Write. LoggingHandler will print 0 as the status code. But client actually get 200.
After ServeHTTP finished, Go HTTP library will call WriteHeader(StatusOK) if wroteHeader is false.
Take a look at the function "finishRequest" in https://github.com/golang/go/blob/master/src/net/http/server.go
So, we should init responseLogger.status with http.StatusOK.