DOM Inspector: Fallback to .childNodes when .children not present#2242
Merged
gorhill merged 1 commit intogorhill:masterfrom Feb 28, 2017
Merged
DOM Inspector: Fallback to .childNodes when .children not present#2242gorhill merged 1 commit intogorhill:masterfrom
gorhill merged 1 commit intogorhill:masterfrom
Conversation
When the browser does not support .children on the svgRoot element (MS Edge, for example), filter childNodes for elements and use that list instead.
ab7cd16 to
4001e38
Compare
Contributor
Author
|
@gorhill, any thoughts on this one? |
Owner
|
Sorry, forgot about this. Looks good to me, thanks. |
Contributor
Author
|
It was over Christmas, I don't blame you. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the browser does not support .children on the svgRoot element (MS Edge, for example), filter childNodes for elements and use that list instead.
Happy to take feedback on the implementation, or location of the helper function to match code style, etc.