Skip to content

Possible regression bug: Preview of CSS 'style' filters no longer works #3257

@yourduskquibbles

Description

@yourduskquibbles

When using the Element Picker tool, clicking preview on filters that contain the CSS modifying :style(foo !important;) tag no longer seems to work. Wondering if this is somehow related to the fix for #3159?

One or more specific URLs where the issue occurs

https://digg.com/

Screenshot in which the issue can be seen

Can post animated gif if needed.

Steps for anyone to reproduce the issue

  1. Navigate to 'https://digg.com'
  2. Use the Element picker tool to click on the header and add the following filter
    ###js--digg-header:style(position: absolute !important;)
  3. Click 'Preview' and scroll down the page, the header SHOULD stay at the top and not be a floating header but in the newest versions of uBlock the preview behavior seems to have stopped working.
  4. In order to confirm this is a valid filter that will pin the header to the top of the screen, click 'Create' and reload the page and observe the correct behavior of the header staying at the top of the screen.
  5. In previous versions of uBlock you used to be able to click 'Preview' and see the impact before having to create the filter.
  6. Is this possibly related to 374e157 which fixed :style filters incorrectly shown in logger #3159?

Your settings

Tested on:

  • Windows 7
  • uBlock Origin dev build 1.14.19.8 on Chrome 62.0.3202.94 (Official Build) (64-bit) AND 1.14.19.b8 on Firefox 57
Your filter lists

Default lists

Your custom filters (if any)

None

Thank you for looking into this, your plugin is awesome! I have a number of people using your plugin and my Annoyances filter list to unsuck the web, one user at a time :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions