Fix potential exception in procedural operator :matches-attr

gorhill · gorhill · commit e07e7bbd094b · 2025-07-18T10:23:11.000-04:00
Related issue: uBlockOrigin/uBlock-issues#3720
diff --git a/platform/mv3/extension/js/scripting/css-procedural-api.js b/platform/mv3/extension/js/scripting/css-procedural-api.js
@@ -119,6 +119,7 @@ class PSelectorMatchesAttrTask extends PSelectorTask {
         this.reValue = regexFromString(task[1].value, true);
     }
     transpose(node, output) {
+        if ( typeof node.getAttributeNames !== 'function' ) { return; }
         const attrs = node.getAttributeNames();
         for ( const attr of attrs ) {
             if ( this.reAttr.test(attr) === false ) { continue; }
diff --git a/src/js/contentscript-extra.js b/src/js/contentscript-extra.js
@@ -99,6 +99,7 @@ class PSelectorMatchesAttrTask extends PSelectorTask {
         this.reValue = regexFromString(task[1].value, true);
     }
     transpose(node, output) {
+        if ( typeof node.getAttributeNames !== 'function' ) { return; }
         const attrs = node.getAttributeNames();
         for ( const attr of attrs ) {
             if ( this.reAttr.test(attr) === false ) { continue; }

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,7 @@ class PSelectorMatchesAttrTask extends PSelectorTask {`
`119`	`119`	`this.reValue = regexFromString(task[1].value, true);`
`120`	`120`	`}`
`121`	`121`	`transpose(node, output) {`
	`122`	`+ if ( typeof node.getAttributeNames !== 'function' ) { return; }`
`122`	`123`	`const attrs = node.getAttributeNames();`
`123`	`124`	`for ( const attr of attrs ) {`
`124`	`125`	`if ( this.reAttr.test(attr) === false ) { continue; }`
Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ class PSelectorMatchesAttrTask extends PSelectorTask {`
`99`	`99`	`this.reValue = regexFromString(task[1].value, true);`
`100`	`100`	`}`
`101`	`101`	`transpose(node, output) {`
	`102`	`+ if ( typeof node.getAttributeNames !== 'function' ) { return; }`
`102`	`103`	`const attrs = node.getAttributeNames();`
`103`	`104`	`for ( const attr of attrs ) {`
`104`	`105`	`if ( this.reAttr.test(attr) === false ) { continue; }`