Minor improvement to trusted-replace-argument scriptlet

gorhill · gorhill · commit da9287257d1b · 2026-06-05T12:00:49.000-04:00
Ensure the `condition` value is stringified before testing it as a
pattern.
diff --git a/src/js/resources/replace-argument.js b/src/js/resources/replace-argument.js
@@ -82,7 +82,7 @@ export function trustedReplaceArgument(
         replacer = ( ) => value;
     }
     const reCondition = extraArgs.condition
-        ? safe.patternToRegex(extraArgs.condition)
+        ? safe.patternToRegex(`${extraArgs.condition}`)
         : /^/;
     const getArg = context => {
         if ( argposRaw === 'this' ) { return context.thisArg; }

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ export function trustedReplaceArgument(`
`82`	`82`	`replacer = ( ) => value;`
`83`	`83`	`}`
`84`	`84`	`const reCondition = extraArgs.condition`
`85`		`- ? safe.patternToRegex(extraArgs.condition)`
	`85`	+ ? safe.patternToRegex(`${extraArgs.condition}`)
`86`	`86`	`: /^/;`
`87`	`87`	`const getArg = context => {`
`88`	`88`	`if ( argposRaw === 'this' ) { return context.thisArg; }`