Improve reporting of reason option in strict-blocked pages

gorhill · gorhill · commit b7510eee6190 · 2025-07-15T12:10:10.000-04:00
Related feedback: uBlockOrigin/uBlock-issues#1195 (comment)
diff --git a/src/css/document-blocked.css b/src/css/document-blocked.css
@@ -73,7 +73,7 @@ a {
     }
 #theURL > p > span:first-of-type {
     display: block;
-    max-height: 6lh;
+    max-height: 3lh;
     overflow-y: auto;
     }
 :root.mobile #theURL > p > span:first-of-type {
@@ -146,6 +146,7 @@ details > *:not(summary) {
 
 #urlskip a {
     display: block;
+    max-height: 3lh;
     overflow-y: auto;
     word-break: break-all;
     }
diff --git a/src/js/pagestore.js b/src/js/pagestore.js
@@ -976,14 +976,12 @@ const PageStore = class {
     skipMainDocument(fctxt, blocked) {
         const directives = staticNetFilteringEngine.urlSkip(fctxt, blocked);
         if ( directives === undefined ) { return; }
-        if ( logger.enabled !== true ) { return; }
         fctxt.pushFilters(directives.map(a => a.logData()));
-        if ( fctxt.redirectURL !== undefined ) {
-            fctxt.pushFilter({
-                source: 'redirect',
-                raw: fctxt.redirectURL
-            });
-        }
+        if ( fctxt.redirectURL === undefined ) { return; }
+        fctxt.pushFilter({
+            source: 'redirect',
+            raw: fctxt.redirectURL
+        });
     }
 
     filterCSPReport(fctxt) {
diff --git a/src/js/traffic.js b/src/js/traffic.js
@@ -221,18 +221,25 @@ const onBeforeRootFrameRequest = function(fctxt) {
 
     // Blocked
 
+    let reason = logData.reason;
+
     // Find out the URL navigated to should the document not be strict-blocked
     pageStore.skipMainDocument(fctxt, false);
 
+    if ( reason === undefined && Array.isArray(fctxt.filter) ) {
+        const filter = fctxt.filter.find(a => a.reason !== undefined);
+        reason = filter?.reason;
+    }
+
     const query = {
         url: requestURL,
         dn: fctxt.getDomain() || requestHostname,
         fs: logData.raw,
         hn: requestHostname,
         to: fctxt.redirectURL || '',
     };
-    if ( logData.reason ) {
-        query.reason = logData.reason;
+    if ( reason ) {
+        query.reason = reason;
     }
 
     vAPI.tabs.replace(

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ a {`
`73`	`73`	`}`
`74`	`74`	`#theURL > p > span:first-of-type {`
`75`	`75`	`display: block;`
`76`		`- max-height: 6lh;`
	`76`	`+ max-height: 3lh;`
`77`	`77`	`overflow-y: auto;`
`78`	`78`	`}`
`79`	`79`	`:root.mobile #theURL > p > span:first-of-type {`
`@@ -146,6 +146,7 @@ details > *:not(summary) {`
`146`	`146`
`147`	`147`	`#urlskip a {`
`148`	`148`	`display: block;`
	`149`	`+ max-height: 3lh;`
`149`	`150`	`overflow-y: auto;`
`150`	`151`	`word-break: break-all;`
`151`	`152`	`}`