Fix version snafu

gorhill · gorhill · commit 50cb780107cb · 2025-09-08T08:11:20.000-04:00
Related issue: uBlockOrigin/uBlock-issues#3792
diff --git a/platform/common/vapi-background.js b/platform/common/vapi-background.js
@@ -48,7 +48,7 @@ vAPI.supportsUserStylesheets = vAPI.webextFlavor.soup.has('user_stylesheet');
 vAPI.app = {
     name: manifest.name.replace(/ dev\w+ build/, ''),
     version: (( ) => {
-        let version = manifest.version;
+        let version = manifest.version_name || manifest.version;
         const match = /(\d+\.\d+\.\d+)(?:\.(\d+))?/.exec(version);
         if ( match && match[2] ) {
             const v = parseInt(match[2], 10);
diff --git a/platform/common/vapi-common.js b/platform/common/vapi-common.js
@@ -166,7 +166,9 @@ vAPI.webextFlavor = {
     soup.add('ipaddress');
 
     // Whether this is a dev build.
-    if ( /^\d+\.\d+\.\d+\D/.test(browser.runtime.getManifest().version) ) {
+    const manifest = browser.runtime.getManifest();
+    const version = manifest.version_name || manifest.version;
+    if ( /^\d+\.\d+\.\d+\D/.test(version) ) {
         soup.add('devbuild');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,9 @@ vAPI.webextFlavor = {`
`166`	`166`	`soup.add('ipaddress');`
`167`	`167`
`168`	`168`	`// Whether this is a dev build.`
`169`		`- if ( /^\d+\.\d+\.\d+\D/.test(browser.runtime.getManifest().version) ) {`
	`169`	`+ const manifest = browser.runtime.getManifest();`
	`170`	`+ const version = manifest.version_name \|\| manifest.version;`
	`171`	`+ if ( /^\d+\.\d+\.\d+\D/.test(version) ) {`
`170`	`172`	`soup.add('devbuild');`
`171`	`173`	`}`
`172`	`174`