Skip to content

fix: [#615] Request InputArray not working for JSON array#970

Merged
almas-x merged 1 commit intomasterfrom
almas/#615
Mar 25, 2025
Merged

fix: [#615] Request InputArray not working for JSON array#970
almas-x merged 1 commit intomasterfrom
almas/#615

Conversation

@almas-x
Copy link
Contributor

@almas-x almas-x commented Mar 25, 2025

📑 Description

Closes goravel/goravel#615

image

✅ Checks

  • Added test cases for my code

@almas-x almas-x requested a review from a team as a code owner March 25, 2025 07:57
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, Great 👍

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.21%. Comparing base (29d08fe) to head (39cae87).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #970   +/-   ##
=======================================
  Coverage   69.21%   69.21%           
=======================================
  Files         160      160           
  Lines       10736    10736           
=======================================
  Hits         7431     7431           
  Misses       2969     2969           
  Partials      336      336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@almas-x
Copy link
Contributor Author

almas-x commented Mar 25, 2025

LGMT, Great 👍

This PR introduces a breaking change to the InputMap function:

Before:

InputMap(key string, defaultValue ...map[string]string) map[string]string

After:

InputMap(key string, defaultValue ...map[string]any) map[string]any

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Mar 25, 2025

Yes, I found that, will introduce this in the upgrade document.

@almas-x almas-x merged commit 1b9ab33 into master Mar 25, 2025
13 checks passed
@almas-x almas-x deleted the almas/#615 branch March 25, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request InputArray for json array doesn't work

2 participants