fix: argon2id configuration override#96
fix: argon2id configuration override#96hwbrzzl merged 2 commits intogoravel:masterfrom devhaozi:fix-argon2id
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master goravel/framework#96 +/- ##
==========================================
+ Coverage 51.52% 51.55% +0.02%
==========================================
Files 103 103
Lines 7028 7032 +4
==========================================
+ Hits 3621 3625 +4
Misses 3126 3126
Partials 281 281
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
hwbrzzl
left a comment
There was a problem hiding this comment.
Great! By the way, could we add a unit test to cover the issue?
Add it. |
| } | ||
|
|
||
| func (s *ApplicationTestSuite) TestConfigurationOverride() { | ||
| value := "$argon2id$v=19$m=65536,t=8,p=1$NlVjQm5PQUdWTHVTM1RBUg$Q5T7WfeCI7ucIdk6Na6AdQ" |
There was a problem hiding this comment.
我们可以根据你自定义配置的发生问题的过程生成这个加密串么？而不是固定写死，这样测试是不是不太能覆盖到问题？
There was a problem hiding this comment.
我们可以根据你自定义配置的发生问题的过程生成这个加密串么？而不是固定写死，这样测试是不是不太能覆盖到问题？
问题的哈希是从数据库取出来的，因为是其他程序生成的，所以参数不一样。
Resolve goravel/goravel#158